Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend-build 12.9.0-alpha.1 in peer dep #529

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jul 31, 2023

Description:

The [email protected] PR includes frontend-build as a peer dependency. Since frontend-app-admin-portal is installed with [email protected], I have added frontend-build 12.9.0-alpha.1 in the Peer Dependency to satisfy frontend-app-admin-portal.

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@Mashal-m Mashal-m requested a review from adamstankiewicz July 31, 2023 06:46
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (760614d) 83.05% compared to head (f882e44) 83.05%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files          40       40           
  Lines        1062     1062           
  Branches      194      194           
=======================================
  Hits          882      882           
  Misses        168      168           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m changed the title chore: add frontend-build 12.9.0-alpha.1 in peer dep Add frontend-build 12.9.0-alpha.1 in peer dep Jul 31, 2023
@Mashal-m Mashal-m force-pushed the mashal-m/update-frontend-build-dep branch from d00c3d3 to f882e44 Compare July 31, 2023 07:23
@abdullahwaheed abdullahwaheed merged commit 6bb07c9 into master Aug 1, 2023
@abdullahwaheed abdullahwaheed deleted the mashal-m/update-frontend-build-dep branch August 1, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants