Skip to content

feat: Change Twitter to X #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Mar 21, 2025

Description

This PR is our proposal to update the Twitter icon to the new X logo in the user Profile and Account.

This PR is related to corresponding PRs in the edx-platform and frontend-app-account repositories.

Снимок экрана 2025-04-15 в 14 04 57 Снимок экрана 2025-04-15 в 14 05 47

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 21, 2025

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 21, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 24, 2025
@Lunyachek Lunyachek force-pushed the lunyachel/feat/change-twitter-to-x-master branch from 3880d81 to 5d57013 Compare April 15, 2025 13:23
@Lunyachek Lunyachek marked this pull request as ready for review April 30, 2025 16:06
@Lunyachek Lunyachek requested a review from a team as a code owner April 30, 2025 16:06
@mphilbrick211
Copy link

Hi @openedx/2u-infinity - could someone please take a look at this? Thanks!

@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants