Deprecate react-unit-test-utils 9/15 #668
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
diana-villalvazo-wgu
added
the
mao-onboarding
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 152 152
Lines 1332 1332
Branches 229 229
=======================================
Hits 1300 1300
Misses 31 31
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| describe('On unverified', () => { | ||
| it('show banner', () => { | ||
| hooks.mockReturnValueOnce({ ...hookProps }); | ||
| render(<IntlProvider locale="en"><ConfirmEmailBanner /></IntlProvider>); | ||
| const banner = screen.getByRole('alert'); | ||
| expect(banner).toContainHTML('Remember to confirm'); | ||
| }); |
There was a problem hiding this comment.
I believe we can de-duplicate some of this code by using beforeAll and mocking the hooks for all tests so that the hooks.mockReturnValueOnce({ ...hookProps }); mock doesn't need to be repeated for each test block.
| describe('On unverified', () => { | |
| it('show banner', () => { | |
| hooks.mockReturnValueOnce({ ...hookProps }); | |
| render(<IntlProvider locale="en"><ConfirmEmailBanner /></IntlProvider>); | |
| const banner = screen.getByRole('alert'); | |
| expect(banner).toContainHTML('Remember to confirm'); | |
| }); | |
| describe('On unverified', () => { | |
| beforeAll(() => { | |
| hooks.mockReturnValue({ ...hookProps }); | |
| }); | |
| it('show banner', () => { | |
| render(<IntlProvider locale="en"><ConfirmEmailBanner /></IntlProvider>); | |
| const banner = screen.getByRole('alert'); | |
| expect(banner).toContainHTML('Remember to confirm'); | |
| }); |
There was a problem hiding this comment.
done 👍
| expect(screen.getByText('MasqueradeBar')).toBeInTheDocument(); | ||
| expect(screen.getByText('Header')).toBeInTheDocument(); | ||
| const props = mockedHeaderProps.mock.calls[0][0]; | ||
| const { mainMenuItems = [] } = props; |
There was a problem hiding this comment.
Is there a need for the default empty array here? I would assume that if mainMenuItems is not in props, we'd see that the test would just fail, which is what we'd want in that case?
| const { mainMenuItems = [] } = props; | |
| const { mainMenuItems } = props; |
There was a problem hiding this comment.
done 👍
diana-villalvazo-wgu
force-pushed
the
649/depr9of15
branch
from
684ea53 to
5e6c9cf
Compare
diana-villalvazo-wgu
force-pushed
the
649/depr9of15
branch
from
5e6c9cf to
440293c
Compare
|
rebased master 👍 |
github-project-automation
bot
moved this from Ready for Review
to Done
in Contributions
Description
Remove use of 'shallow' (react-unit-test-utils) in following files:
Note: As part of this work we find out paragon components were mocked on src/setupTest.jsx causing testing library unit tests to fail, since we are doing this work in multiple PRs and in order to not break other existing snapshot tests, we will unmock paragon or needed things on new tests and by end of react-unit-test-utils removal we will remove paragon mocks and unmock lines accordingly.
Support Information
Closes #649