Fix Error in the Courses link Issue 415 #446
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @jciasenza! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
itsjeyd
added
the
needs test run
|
Hey @jciasenza it looks like this is no longer passing CI and needs to be updated with the latest from the |
MaxFrank13
added
the
waiting on author
|
@jciasenza looks like there are some failing checks, can you have a look? |
e0d
removed
the
needs test run
|
I review it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 157 157
Lines 1387 1387
Branches 230 230
=======================================
Hits 1351 1351
Misses 34 34
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
I made a new push with some test changes, because in production it seems that the Courses link works well, that is to say that I made that change back |
|
Hey @jciasenza, it looks like there are some commitlint failures left to fix. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
itsjeyd
added
needs test run
|
@jciasenza While this is waiting for another test run, maybe you could bring your changes up-to-date with the |
itsjeyd
added
the
waiting on author
|
Thanks for taking action here @jciasenza! @e0d or @openedx/2u-aperture Could you run another build for this PR, please? |
itsjeyd
removed
the
waiting on author
src/test/app.test.jsx
Outdated
| initialize, | ||
| mergeConfig, | ||
| } from '@edx/frontend-platform'; | ||
| // import userEvent from '@testing-library/user-event'; |
There was a problem hiding this comment.
Why is this commented out instead of removed?
There was a problem hiding this comment.
I made a new push to remove those unnecessary lines
mphilbrick211
removed
the
needs test run
Fixes #415
What changed?
frontend-app-learner-dashboard/src/containers/LearnerDashboardHeader/LearnerDashboardMenu.jsx
in line 16
remplace
href ='/'
by
href =''
If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)
Developer Checklist
Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
I've done a visual code review
FYI: @openedx/content-aurora