Skip to content

TIA-41: Added * for required fields in labels #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zubairshakoorarbisoft
Copy link

Description

On Discussion page, while adding the post, Compulsory fields are missing the required alert sign (e.g. Asterisk). So, I've added Asterisk sign on post title and content area to prevent user from posting content without it. This will prevent the error message and save user time.

Steps to Reproduce:
Open Sandbox URL

  1. Through keyboard tap on topics tab.
  2. Select Enter
  3. Now press tab again it will focus on the modules.
  4. Select Enter again
  5. It will expand the module section
  6. Now select Tab
  7. It will move the focus to “Add a post” section"

Related to overhangio/tutor-indigo#146

How Has This Been Tested?

I set up Tutor locally with the Indigo Plugin enabled (which is enabled by default). I followed the above steps to reproduce the issue, inspected the HTML on the frontend, and identified where the adjustment was needed.

Sandbox (optional):

Sandbox Link

Following Taiga tickets has been addressed in this PR(Access required):

  1. https://tree.taiga.io/project/zaraahmed-tutor-indigo-accessibility/us/41

Screenshots

Before
image

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@@ -409,6 +409,7 @@ const PostEditor = ({
value={values.comment}
onEditorChange={formikCompatibleHandler(handleChange, 'comment')}
onBlur={formikCompatibleHandler(handleBlur, 'comment')}
placeholder={'Post content*'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be translated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wittjeff
Copy link

If the Post Title field is required, it should have required attribute on the input. The asterisk is not a complete substitute for the same semantic info under WCAG 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants