Skip to content

fix: fixed Tabs menu is not displaying the "more" button #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bydawen
Copy link

@bydawen bydawen commented May 20, 2025

Fixed issue Tabs course menu is not displaying the "more" button for responsive support

Refactor code functionality with ResizeObserver to prevent bug on first time page loading and reduce the amount of code that used outdated window size method.

Video with bug fixed:

qwss3521.mov

@openedx-webhooks
Copy link

openedx-webhooks commented May 20, 2025

Thanks for the pull request, @bydawen!

This repository is currently maintained by @openedx/edx-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 20, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 20, 2025
@bydawen bydawen marked this pull request as draft May 20, 2025 09:08
@bydawen bydawen marked this pull request as ready for review May 20, 2025 09:27
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label May 27, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (ac471e2) to head (2179d4c).

Files with missing lines Patch % Lines
...s/NavigationBar/tabs/useIndexOfLastVisibleChild.js 87.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   93.15%   93.10%   -0.05%     
==========================================
  Files         161      161              
  Lines        3402     3409       +7     
  Branches      919      916       -3     
==========================================
+ Hits         3169     3174       +5     
- Misses        216      218       +2     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@e0d
Copy link

e0d commented May 27, 2025

@bydawen can you have a look at the coverage issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Tests Run or CLA Signed
Development

Successfully merging this pull request may close these issues.

4 participants