Skip to content

fix: wrap meaningful icons with text to improve screen reader output #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arbirali
Copy link

@arbirali arbirali commented May 12, 2025

Description

On the Discussions page, screen reader–only text has been added to icons without labels, and aria-hidden="true" has been applied to icons that already have visible text.


Steps to reproduce:

Related to overhangio/tutor-indigo#146

How Has This Been Tested?

I set up Tutor locally with the Indigo plugin enabled (enabled by default) and followed the steps above to reproduce the issue. By inspecting the frontend HTML, I identified the required adjustment. After applying the fix, keyboard navigation using the Tab key now works correctly for both selected and non-selected options.

Screenshots/sandbox (optional):

Sandbox Link
Taiga Ticket (If someone have access)

image

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@awais-ansari
Copy link
Contributor

Please update the test cases. The required checks are failing. Other than that, the changes look good to me.

@awais-ansari awais-ansari self-requested a review May 26, 2025 06:45
@wittjeff
Copy link

Please post examples of the new text "visible" to screen reader users with this change in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants