-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update react & react-dom to v17 #514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 86.81% 86.43% -0.39%
==========================================
Files 378 378
Lines 5697 5697
Branches 1258 1258
==========================================
- Hits 4946 4924 -22
- Misses 729 749 +20
- Partials 22 24 +2 ☔ View full report in Codecov by Sentry. |
BilalQamar95
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
2 times, most recently
from
August 15, 2023 09:02
9064207
to
83c1292
Compare
BilalQamar95
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
from
September 11, 2023 10:46
b305feb
to
f4a412b
Compare
BilalQamar95
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
3 times, most recently
from
September 26, 2023 10:23
729bef4
to
af6226f
Compare
BilalQamar95
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
from
October 2, 2023 10:12
af6226f
to
6974364
Compare
BilalQamar95
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
from
October 2, 2023 11:25
742136c
to
c86e751
Compare
BilalQamar95
force-pushed
the
bilalqamar95/react-upgrade-to-v17
branch
2 times, most recently
from
October 5, 2023 11:50
389da43
to
136267c
Compare
kenclary
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react
&react-dom
to v17 along with other packages to respective versionsenzyme-adapter-react-16
with@wojtekmaj/enzyme-adapter-react-17