Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #514

Merged
merged 14 commits into from
Oct 11, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 9, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17 along with other packages to respective versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated edx packages

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3fe3534) 86.81% compared to head (2fe53d0) 86.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   86.81%   86.43%   -0.39%     
==========================================
  Files         378      378              
  Lines        5697     5697              
  Branches     1258     1258              
==========================================
- Hits         4946     4924      -22     
- Misses        729      749      +20     
- Partials       22       24       +2     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch 2 times, most recently from 9064207 to 83c1292 Compare August 15, 2023 09:02
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch from b305feb to f4a412b Compare September 11, 2023 10:46
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch 3 times, most recently from 729bef4 to af6226f Compare September 26, 2023 10:23
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch from af6226f to 6974364 Compare October 2, 2023 10:12
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch from 742136c to c86e751 Compare October 2, 2023 11:25
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/react-upgrade-to-v17 branch 2 times, most recently from 389da43 to 136267c Compare October 5, 2023 11:50
@BilalQamar95 BilalQamar95 marked this pull request as ready for review October 6, 2023 10:44
Copy link
Contributor

@kenclary kenclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@BilalQamar95 BilalQamar95 merged commit 97d0a1c into master Oct 11, 2023
4 of 5 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/react-upgrade-to-v17 branch October 11, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants