-
Notifications
You must be signed in to change notification settings - Fork 133
Display Container Publish status and confirm before publish #2186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Display Container Publish status and confirm before publish #2186
Conversation
so we can use it in both containers and section-subsection
Thanks for the pull request, @pomegranited! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
feafb0c
to
1f096b7
Compare
%draft-status { | ||
background-color: #FDF3E9; | ||
border-color: #F4B57B !important; | ||
color: #00262B; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a design token color for these? see e.g https://github.com/openedx/paragon/blob/f154be3332d917db51fdb68bf9d20e891212f69a/styles/css/themes/light/variables.css#L640
8557399
to
7ab9e25
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
+ Coverage 94.10% 94.11% +0.01%
==========================================
Files 1164 1165 +1
Lines 24495 24552 +57
Branches 5310 5319 +9
==========================================
+ Hits 23050 23107 +57
+ Misses 1377 1368 -9
- Partials 68 77 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Had to convert generic/Loading.jsx to tsx to make this work.
Description
Updates the Container sidebar to display:
Content Library Authors are affected by this change.
Supporting information
Part of:
Depends on:
Private-ref: FAL-4178
Testing instructions
Please provide detailed step-by-step instructions for testing this change.