Add subsection/unit to section/subsection full-page view within library [FC-0090] #2152

pomegranited · 2025-06-15T16:14:28Z

Description

Removes the "content type" tab bar from the "Add Existing Component/Unit/Subsection" modal, and in all cases where only one type of content is shown for selection.
Updates the section/subsection sidebar to show "Existing Library Content" + "New Subsection" / "New Unit" buttons.
Updates the "Add New Unit/Subsection" buttons to directly launch the new container modal, instead of going via the container sidebar.
Ensures that whenever a subsection/unit is created from within a section/subsection, that it is linked to the parent section/subsection after created.

Affects Library Content Authors.

Supporting information

Part of Add existing subsection/unit to section/subsection full-page view within library #1969
Private-ref: FAL-4172

Testing instructions

Code review: Recommend working through commit by commit.

Create a new Library.
Create a new Section.
From the Section page, click "Add New Subsection".
Ensure that the new Subsection is shown, and that its breadcrumbs reflect that it was added the Section
From the Subsection page, click "Add New Unit".
Ensure that the new Unit is shown. Navigate back to the Subsection to see that the Unit was added to the Subsection (see notes below).
Repeat the steps above using the sidebar buttons.
Ensure that the "Add Existing Subsection/Unit" buttons still work as expected.

Other information

A unit's membership in one or more subsections is not currently represented on the unit page (unlike subsections, whose membership in one or more sections is shown in the breadcrumbs). Fixing this is out of scope for this issue.

to make it easier to show or hide the "add new component" buttons. Also removes the need to convert between Chapter => Section, Sequential => Subsection, and Vertical => Unit.

instead of just opening the sidebar, when adding a container to another container. This saves the user a click and makes this consistent with the "add new component" button on unit page.

openedx-webhooks · 2025-06-15T16:14:33Z

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-06-15T16:24:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (ebf4b7c) to head (a54a06a).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #2152    +/-   ##
========================================
  Coverage   94.12%   94.13%            
========================================
  Files        1164     1164            
  Lines       24527    24540    +13     
  Branches     5339     5220   -119     
========================================
+ Hits        23086    23100    +14     
- Misses       1364     1372     +8     
+ Partials       77       68     -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pomegranited · 2025-06-18T17:05:41Z

src/library-authoring/units/LibraryUnitPage.test.tsx

+    expect(await screen.findByRole('button', { name: /existing library content/i })).toBeInTheDocument();
+    expect(await screen.findByRole('button', { name: /text/i })).toBeInTheDocument();
+    expect(await screen.findByRole('button', { name: /problem/i })).toBeInTheDocument();
+  });
 });


Also need to remove the testIf skipped tests from ContainerInfo.test;

Ah my mistake -- we can reinstate one of them, but the other relies on https://github.com/openedx/frontend-app-authoring/pull/2145/files#r2155581898

cf ec74917

bradenmacdonald · 2025-06-18T19:17:32Z

A unit's membership in one or more subsections is not currently represented on the unit page (unlike subsections, whose membership in one or more sections is shown in the breadcrumbs). Fixing this is out of scope for this issue.

Is there an issue to track that somewhere? I did notice this when testing.

bradenmacdonald

👍 Seems good! Please just rebase / merge master and make sure it's working again before we can merge it. Also let me know about my minor comment and the testIf thing you mentioned.

I tested this: as suggested
I read through the code
I checked for accessibility issues
Includes documentation

bradenmacdonald · 2025-06-18T19:08:54Z

src/library-authoring/add-content/AddContent.tsx

@@ -37,7 +37,7 @@ import { ContainerType } from '../../generic/key-utils';

 type ContentType = {
  name: string,
-  disabled: boolean,
+  disabled?: boolean,
  icon?: React.ComponentType,


Suggested change

icon?: React.ComponentType,

Can we delete this icon field now? Seems to be unused after these changes.

Ah, I made a mistake here -- we do need that icon parameter so we can show the little sparkle next to "Advanced / Other":

Fixed with 2e50209.

ChrisChV · 2025-06-18T21:42:12Z

A unit's membership in one or more subsections is not currently represented on the unit page (unlike subsections, whose membership in one or more sections is shown in the breadcrumbs). Fixing this is out of scope for this issue.

No, but I asked to Product for the exact feature

ChrisChV · 2025-06-19T20:09:23Z

@pomegranited Looks good! I found some issues:

On the section page, we need to change the first button to Existing Subsection and the second button to New Subsection. The same on the Subsection page.

On the select subsection modal, we need to remove the Type filter. The same on the select unit modal.

to make it easier to type these variables in other places

When adding units to a subsection: * button names are "Add Unit" and "Existing Unit" * modal title and text is "Select units" and "N units selected" * modal button is "Add to subsection" When adding subsection to a section: * button names are "Add Subsection" and "Existing Subsection" * modal title and text is "Select subsections" and "N subsections selected" * modal button is "Add to section" Otherwise, the more generic "component" text is used.

pomegranited · 2025-06-20T18:19:10Z

@ChrisChV

On the section page, we need to change the first button to Existing Subsection and the second button to New Subsection. The same on the Subsection page.

Done with 3c62925.

I also updated the "Select components" and "N components selected" text to be consistent with the context.

On the select subsection modal, we need to remove the Type filter. The same on the select unit modal.

So, this would be harder to do, so I haven't done it.

Since the search modal isn't aware of the library routing context, we'd have to add something to the LibraryContext to pass this context through, like we do with showOnlyPublished and FilterByPublishedStatus.

ChrisChV · 2025-06-20T19:53:43Z

Done with 3c62925.

I also updated the "Select components" and "N components selected" text to be consistent with the context.

Thanks! Works great!

So, this would be harder to do, so I haven't done it.

Since the search modal isn't aware of the library routing context, we'd have to add something to the LibraryContext to pass this context through, like we do with showOnlyPublished and FilterByPublishedStatus.

@pomegranited What do you think about adding visibleFilters in LibraryAuthoringPage and ComponentPicker, like visibleTabs?

pomegranited · 2025-06-22T18:38:56Z

@ChrisChV

What do you think about adding visibleFilters in LibraryAuthoringPage and ComponentPicker, like visibleTabs?

Ah, turned out to be even easier than that :) 50aedd2

ChrisChV

Looks good 👍 Please, fix the CI to merge the PR

pomegranited · 2025-06-23T20:29:21Z

@ChrisChV Done :) Tests will pass now.

pomegranited added 4 commits June 16, 2025 01:05

feat: remove content picker tab bar when only 1 visible tab

107f13f

refactor: simplify AddContent

4f17d8b

to make it easier to show or hide the "add new component" buttons. Also removes the need to convert between Chapter => Section, Sequential => Subsection, and Vertical => Unit.

feat: implements "add container to parent container"

509dbe8

fix: allow "add new" button to open new container modal

5df2459

instead of just opening the sidebar, when adding a container to another container. This saves the user a click and makes this consistent with the "add new component" button on unit page.

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 15, 2025

openedx-webhooks added this to Contributions Jun 15, 2025

github-project-automation bot moved this to Needs Triage in Contributions Jun 15, 2025

test: adds tests for adding children to container

9aa7b70

pomegranited marked this pull request as ready for review June 15, 2025 23:55

pomegranited requested review from navinkarkera and ChrisChV June 15, 2025 23:57

test: ensure Unit Add Content sidebar is opened on "add new content"

b68de23

pomegranited removed the request for review from ChrisChV June 17, 2025 15:44

pomegranited commented Jun 18, 2025

View reviewed changes

bradenmacdonald approved these changes Jun 18, 2025

View reviewed changes

pomegranited added 2 commits June 19, 2025 07:14

Merge remote-tracking branch 'origin/master' into jill/add-to-container

93c901f

fix: reinstate custom icon for add content buttons

2e50209

pomegranited force-pushed the jill/add-to-container branch from d4ffcf9 to 2e50209 Compare June 18, 2025 22:01

test: reinstate one skipped test

ec74917

pomegranited requested a review from ChrisChV June 18, 2025 22:08

pomegranited added 2 commits June 21, 2025 03:27

refactor: make library routes return booleans for inside*

aba7f70

to make it easier to type these variables in other places

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jun 20, 2025

mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jun 20, 2025

feat: hide Types filter in the section/subsection content picker

50aedd2

Merge remote-tracking branch 'origin/master' into jill/add-to-container

8cee31f

ChrisChV approved these changes Jun 23, 2025

View reviewed changes

Merge remote-tracking branch 'origin/master' into jill/add-to-contain

a54a06a

ChrisChV merged commit 747f7b6 into openedx:master Jun 24, 2025
7 checks passed

github-project-automation bot moved this from In Eng Review to Done in Contributions Jun 24, 2025

Add subsection/unit to section/subsection full-page view within library [FC-0090] #2152

Add subsection/unit to section/subsection full-page view within library [FC-0090] #2152

Uh oh!

Conversation

pomegranited commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Other information

Uh oh!

openedx-webhooks commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pomegranited Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

pomegranited Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald commented Jun 18, 2025

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

pomegranited Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChrisChV commented Jun 18, 2025

Uh oh!

ChrisChV commented Jun 19, 2025

Uh oh!

pomegranited commented Jun 20, 2025

Uh oh!

ChrisChV commented Jun 20, 2025

Uh oh!

pomegranited commented Jun 22, 2025

Uh oh!

ChrisChV left a comment

Choose a reason for hiding this comment

Uh oh!

pomegranited commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

pomegranited commented Jun 15, 2025 •

edited

Loading

openedx-webhooks commented Jun 15, 2025 •

edited

Loading

codecov bot commented Jun 15, 2025 •

edited

Loading

pomegranited Jun 18, 2025 •

edited

Loading

pomegranited Jun 18, 2025 •

edited

Loading