Skip to content

feat: fix toolbar of text editor at top while scrolling #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Faraz32123
Copy link
Contributor

Ticket: TNL-11969
In this PR, fixed toolbar of text editor at the top even while scrolling.

Before:
before

After:
after

@Faraz32123 Faraz32123 self-assigned this May 21, 2025
@Faraz32123 Faraz32123 force-pushed the feat/fix_toolbar_of_text_editor_at_top_during_scrolling branch from 79d9278 to 4a63b2b Compare May 21, 2025 10:03
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (e212e1a) to head (4a63b2b).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
+ Coverage   93.95%   93.96%   +0.01%     
==========================================
  Files        1154     1154              
  Lines       24098    24098              
  Branches     5207     5206       -1     
==========================================
+ Hits        22641    22644       +3     
+ Misses       1380     1377       -3     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@rayzhou-bit rayzhou-bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is under the problem editor folder. Is that right?

@Faraz32123
Copy link
Contributor Author

This file is under the problem editor folder. Is that right?

yes, Should we create a new file? Cause tox & tinymce related css was there, And those were also related to editors.

@rayzhou-bit rayzhou-bit self-requested a review May 30, 2025 16:16
Copy link
Contributor

@rayzhou-bit rayzhou-bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by adding large images and it's working well.

Ideally, there should be an scss file for TextEditor as well but I can see this scss is affecting both text and problem editors. Let's just leave it all in the current file for now since it's a fix.

Nit change: I tried moving all the selectors under .tinyMceWidget into .pgn__modal-body-content and that works. It would remove some duplicate selectors and would work for both text and problem.

@Faraz32123 Faraz32123 merged commit 0c7cef6 into master Jun 2, 2025
7 checks passed
@Faraz32123 Faraz32123 deleted the feat/fix_toolbar_of_text_editor_at_top_during_scrolling branch June 2, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants