Skip to content

feat: Unit settings in libraries #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: Unit settings in libraries #1912

wants to merge 2 commits into from

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented May 6, 2025 •
edited
Loading

Description

  • Adds the Settings tab in the Unit info sidebar.
  • All are connected with the backend and are functional.
  • Which edX user roles will this change impact? "Course Author".

image

Supporting information

Testing instructions

Other information

N/A

@openedx-webhooks
Copy link

openedx-webhooks commented May 6, 2025 •
edited
Loading

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 6, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 6, 2025
@ChrisChV ChrisChV marked this pull request as draft May 6, 2025 01:16
This was referenced May 6, 2025
Open
Draft
@ChrisChV ChrisChV marked this pull request as ready for review May 6, 2025 01:30
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label May 6, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions May 6, 2025
rpenido
rpenido approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @ChrisChV!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

src/library-authoring/containers/messages.ts
unitVisibilityStudentLabel: {
id: 'course-authoring.library-authoring.unit.settings.visibility.student',
defaultMessage: 'Student Visible',
description: 'Label of the button for set the unit as student visible on unit settins.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Suggested change
description: 'Label of the button for set the unit as student visible on unit settins.',
description: 'Label of the button for set the unit as student visible on unit settings.',

src/library-authoring/containers/messages.ts
unitVisibilityStaffLabel: {
id: 'course-authoring.library-authoring.unit.settings.visibility.staff',
defaultMessage: 'Staff Only',
description: 'Label of the button for set the unit as staff only visible on unit settins.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Label of the button for set the unit as staff only visible on unit settins.',
description: 'Label of the button for set the unit as staff only visible on unit settings.',

@mphilbrick211
Copy link

Hi @ChrisChV! Is this pull request still in progress?

@ChrisChV ChrisChV marked this pull request as draft June 23, 2025 18:02
@ChrisChV
Copy link
Contributor Author

Hi @mphilbrick211, this work is blocked: openedx/openedx-learning#312 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpenido rpenido rpenido approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisChV @openedx-webhooks @mphilbrick211 @rpenido