Skip to content

feat: Added email for new learner credit requests #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: Added email for new learner credit requests #774

wants to merge 1 commit into from

Conversation

zamanafzal
Copy link
Member

Description:
Added email functionality for new learner credit requests

Jira:
ENT-10341

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

@zamanafzal zamanafzal force-pushed the zafzal/ENT-10341 branch 2 times, most recently from e03ff87 to a3441e0 Compare July 8, 2025 06:10
sameenfatima78
sameenfatima78 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one suggestion

enterprise_access/apps/subsidy_request/tasks.py Outdated
Comment on lines 167 to 170
subsidy_requests = subsidy_model.objects.filter(
enterprise_customer_uuid=enterprise_customer_uuid,
state=SubsidyRequestStates.REQUESTED,
).order_by("-created")[:6]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are redirecting the admin on a specific budget page, we should filter the requests here on policy_uuid. This will prevent confusion if a customer has multiple policies configured with B&R.

@zamanafzal zamanafzal closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameenfatima78 sameenfatima78 sameenfatima78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zamanafzal @sameenfatima78