-
Notifications
You must be signed in to change notification settings - Fork 4.2k
chore: [FC-7879] bump edx-when version to 3.2.0 #37867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @Serj-N! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@Serj-N You need to include this change in the previous PR. No need to create separate PR for the version bump. We want the change and version bump to be in the same PR. |
|
@UsamaSadiq Yes, that's what I did in the edx-when PR. But from Ed's comment, I thought we should also update the dependency version in the edx-platform and any other repos using edx-when. If I that's not the case, then I suppose the version update is done? |
|
This PR will be created once edx-when PR is merged and a new version is published on PyPI. Until, the new version is published CI will fail on this PR and edx-platform already has a scheduled requirements upgrade workflow which updates packages on weekly basis. |
|
Makes sense, thanks for the clarification! |
Yes, no further action should be required from your end. Thanks for this contribution. |
Summary
Bump
edx-whenversion to3.2.0.Related PR
openedx/edx-when#343