-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Build with newer ruby and mongo versions. #426
Conversation
7ff22db
to
2338ef5
Compare
2338ef5
to
38f515e
Compare
docker run -it -v .:/app -u 1000:1000 -e BUNDLE_GEMFILE=Gemfile3 -w /app ruby:3.0 bundle update
Use the original Gemfile because we don't need to support ruby 2.x anymore so this was just cruft. I copied over Gemfile3 as a starting point to Gemfile and then ran `bundle update` on Ruby 3.1
As a part of this, I dropped the pin on nokogiri since that is a downstream dependency of `will_paginate_mongoid` which is the actual dependency we care about.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 58 58
Lines 4588 4588
=======================================
Hits 4412 4412
Misses 176 176 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for keeping this moving!
Thanks @feanil. Testing was started today. I'll post any updates and issue list (if any) here. |
@feanil
No difference with Ruby 3.0 has been found. I've tested on Tutor nightly with updated Dockerfile:
Minor issues not related to Ruby but to the Forum service:
|
@cmltaWt0 it looks like CI passed ruby 3.3 and mongo 7, can you test with those as well? If things look good, we can get this landed and tutor updated to the latest ruby and we'll know we can update mongo when we're ready for that on the edx-platform side. We can leave the current matrix in place until we can drop the older versions. |
Yeap. Will do! |
All manual tests were successfully passed in two different configurations:
No issues have been found. |
I've notified the tutor maintainers here to update nightly: https://discuss.openedx.org/t/cs-comment-service-upgrade/12472 |
No description provided.