Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Build with newer ruby and mongo versions. #426

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Feb 22, 2024

No description provided.

@feanil feanil force-pushed the feanil/run_all_the_tests branch 2 times, most recently from 7ff22db to 2338ef5 Compare February 22, 2024 03:01
@feanil feanil force-pushed the feanil/run_all_the_tests branch from 2338ef5 to 38f515e Compare February 22, 2024 03:05
Feanil Patel added 3 commits February 21, 2024 23:36
docker run -it -v .:/app -u 1000:1000 -e BUNDLE_GEMFILE=Gemfile3 -w /app ruby:3.0 bundle update
Use the original Gemfile because we don't need to support ruby 2.x
anymore so this was just cruft.

I copied over Gemfile3 as a starting point to Gemfile and then ran
`bundle update` on Ruby 3.1
As a part of this, I dropped the pin on nokogiri since that is a
downstream dependency of `will_paginate_mongoid` which is the actual
dependency we care about.
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (ac710bf) to head (5778b50).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          58       58           
  Lines        4588     4588           
=======================================
  Hits         4412     4412           
  Misses        176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feanil feanil marked this pull request as ready for review February 22, 2024 05:06
@feanil feanil changed the title build: Build with newer ruby and mongo versions. build: Build with newer ruby versions. Feb 22, 2024
Copy link
Contributor

@blarghmatey blarghmatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for keeping this moving!

@feanil
Copy link
Contributor Author

feanil commented Feb 26, 2024

@cmltaWt0 just putting here what we spoke about in slack.

@cmltaWt0 is going to get some manual testing done with the new ruby version and if it looks good, we can merge this change and start upgrading tutor-nightly to the new ruby version.

@cmltaWt0
Copy link

Thanks @feanil.

Testing was started today. I'll post any updates and issue list (if any) here.

@cmltaWt0
Copy link

cmltaWt0 commented Feb 28, 2024

@feanil
The testing is complete.
The following areas were covered:

Check that u can post msg (inactive)
Check that u can edit msg (inactive)
Check that u can add an image.
Check that u can add an emoji in the header
Check that u can't post without a header / body
Check that u can copy link
Check that u can report post (inactive)
Check that u can delete post (inactive)

Check that u can like your post (

Check that u can star post (follow) 

Check that u can respond to post 

Check that your username is viewable
Check that u can report post
Check that u can unreport post
Check that u your username isn’t clickable in unit (inactive) 

Check that u your username clickable in forum (inactive)

Check that u can add response to post

Check that u can add response to response 

Check that u can sort posts:

following -
unread +
unanswered Q +
not responded + 


Check that u can delete user and check the posts
as a staff
Check that u can close the post
Check that u can moderate post
Check that u can delete post
Check that u can edit post
Check that u can endorsed post
Check that u can retire a user
Check that u can search for a Topic
Check that u can search for a User
Check that u can search for a Content

No difference with Ruby 3.0 has been found.

I've tested on Tutor nightly with updated Dockerfile:

- FROM docker.io/ruby:3.0.5-slim-bullseye
+ FROM docker.io/ruby:3.1.4-slim-bullseye
...
- ENV BUNDLE_GEMFILE Gemfile3
+ ENV BUNDLE_GEMFILE Gemfile

Minor issues not related to Ruby but to the Forum service:

  • Following filter doesn't work ("developer_message": "The following query parameters are mutually exclusive: topic_id, text_search, following") ((will report as an issue))
  • UI/markup bug after loading all posts (will report as an issue)

@feanil
Copy link
Contributor Author

feanil commented Mar 1, 2024

@cmltaWt0 it looks like CI passed ruby 3.3 and mongo 7, can you test with those as well? If things look good, we can get this landed and tutor updated to the latest ruby and we'll know we can update mongo when we're ready for that on the edx-platform side. We can leave the current matrix in place until we can drop the older versions.

@cmltaWt0
Copy link

cmltaWt0 commented Mar 1, 2024

@cmltaWt0 it looks like CI passed ruby 3.3 and mongo 7, can you test with those as well? If things look good, we can get this landed and tutor updated to the latest ruby and we'll know we can update mongo when we're ready for that on the edx-platform side. We can leave the current matrix in place until we can drop the older versions.

Yeap. Will do!

@feanil feanil changed the title build: Build with newer ruby versions. build: Build with newer ruby and mongo versions. Mar 4, 2024
@cmltaWt0
Copy link

cmltaWt0 commented Mar 6, 2024

@feanil

All manual tests were successfully passed in two different configurations:

  • Ruby 3.3.0 + Mongo 4.4
  • Ruby 3.3.0 + Mongo 7.0.6

No issues have been found.

@feanil feanil merged commit fb969c2 into master Mar 7, 2024
16 checks passed
@feanil feanil deleted the feanil/run_all_the_tests branch March 7, 2024 20:17
@feanil
Copy link
Contributor Author

feanil commented Mar 7, 2024

I've notified the tutor maintainers here to update nightly: https://discuss.openedx.org/t/cs-comment-service-upgrade/12472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants