Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zfs-localpv): add option for choosing between refquota and quota #542

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cinapm
Copy link

@cinapm cinapm commented Jun 13, 2024

Why is this PR required? What issue does it fix?:
resolve this issue: #423

What this PR does?:
this PR adds an option for choosing between refquota or quota and uses this value as zfs command options

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@1b0b77e). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #542   +/-   ##
==========================================
  Coverage           ?   99.53%           
==========================================
  Files              ?        1           
  Lines              ?      431           
  Branches           ?        0           
==========================================
  Hits               ?      429           
  Misses             ?        1           
  Partials           ?        1           
Flag Coverage Δ
bddtests 99.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/main.go Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
@Abhinandan-Purkait
Copy link
Member

Thanks @cinapm. Looks good to me. I will let other folks review this. We will target this for this upcoming release.

@dsharma-dc
Copy link

Have we tested this change by trying to apply a quota, and then a refquota underneath that dataset?
Add a simple test as well perhaps.

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration option should be toggle-able through a storageclass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants