-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zfs-localpv): add option for choosing between refquota and quota #542
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #542 +/- ##
==========================================
Coverage ? 99.53%
==========================================
Files ? 1
Lines ? 431
Branches ? 0
==========================================
Hits ? 429
Misses ? 1
Partials ? 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @cinapm. Looks good to me. I will let other folks review this. We will target this for this upcoming release. |
Have we tested this change by trying to apply a quota, and then a refquota underneath that dataset? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration option should be toggle-able through a storageclass.
Signed-off-by: cina_pm <[email protected]>
Why is this PR required? What issue does it fix?:
resolve this issue: #423
What this PR does?:
this PR adds an option for choosing between refquota or quota and uses this value as zfs command options
Checklist:
<type>(<scope>): <subject>