chore(bors): merge pull request #535

535: fix: listen on the IPv6 unspecified address r=tiagolobocastro a=michaelbeaumont ## Description Use the IPv6 unspecified address instead of IPv4 so IPv6/dual stack clusters work. ## Motivation and Context Closes openebs/mayastor#1730 Mayastor is currently unusable when the IPv6 is the primary IP family. ## How Has This Been Tested? I've only tested the helm chart changes. ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <! Co-authored-by: Mike Beaumont <[email protected]>
openebs · Oct 7, 2024 · 6238e84 · 6238e84
2 parents 8055f61 + eb0d508
commit 6238e84
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/call-home/src/bin/stats/main.rs b/call-home/src/bin/stats/main.rs
@@ -44,7 +44,7 @@ struct Cli {
     release_name: String,
 
     /// TCP address where events stats are exposed.
-    #[clap(long, short, default_value = "0.0.0.0:9090")]
+    #[clap(long, short, default_value = "[::]:9090")]
     metrics_endpoint: SocketAddr,
 
     /// Interval to update the config map.

diff --git a/chart/templates/mayastor/agents/core/agent-core-deployment.yaml b/chart/templates/mayastor/agents/core/agent-core-deployment.yaml
@@ -50,7 +50,7 @@ spec:
             - "--request-timeout={{ .Values.base.default_req_timeout }}"
             - "--cache-period={{ .Values.base.cache_poll_period }}"{{ if .Values.base.jaeger.enabled }}
             - "--jaeger={{ include "jaeger_url" . }}"{{ end }}
-            - "--grpc-server-addr=0.0.0.0:50051"
+            - "--grpc-server-addr=[::]:50051"
             - "--pool-commitment={{ .Values.agents.core.capacity.thin.poolCommitment }}"
             - "--snapshot-commitment={{ .Values.agents.core.capacity.thin.snapshotCommitment }}"
             - "--volume-commitment-initial={{ .Values.agents.core.capacity.thin.volumeCommitmentInitial }}"
@@ -94,7 +94,7 @@ spec:
           image: "{{ .Values.image.registry }}/{{ .Values.image.repo }}/{{ include "image_prefix" . }}-agent-ha-cluster:{{ default .Values.image.tag .Values.image.repoTags.controlPlane }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           args:
-            - "-g=0.0.0.0:50052"
+            - "-g=[::]:50052"
             - "--store=http://{{ include "etcdUrl" . }}"
             - "--core-grpc=https://{{ .Release.Name }}-agent-core:50051"{{ if .Values.base.jaeger.enabled }}
             - "--jaeger={{ include "jaeger_url" . }}"{{ end }}{{ if .Values.eventing.enabled }}

diff --git a/chart/templates/mayastor/apis/api-rest-deployment.yaml b/chart/templates/mayastor/apis/api-rest-deployment.yaml
@@ -47,7 +47,7 @@ spec:
           args:
             - "--dummy-certificates"
             - "--no-auth"
-            - "--http=0.0.0.0:8081"
+            - "--http=[::]:8081"
             - "--request-timeout={{ .Values.base.default_req_timeout }}"{{ if .Values.base.jaeger.enabled }}
             - "--jaeger={{ include "jaeger_url" . }}"{{ end }}
             - "--core-grpc=https://{{ .Release.Name }}-agent-core:50051"

diff --git a/metrics-exporter/src/bin/io_engine/main.rs b/metrics-exporter/src/bin/io_engine/main.rs
@@ -40,7 +40,7 @@ fn get_node_name() -> Result<String, ExporterError> {
 #[clap(name = utils::package_description!(), version = utils::version_info_str!())]
 pub(crate) struct Cli {
     /// TCP address where prometheus endpoint will listen to
-    #[clap(long, short, default_value = "0.0.0.0:9502")]
+    #[clap(long, short, default_value = "[::]:9502")]
     metrics_endpoint: SocketAddr,
 
     /// Formatting style to be used while logging.