Skip to content

Commit 6238e84

Browse files
mayastor-borsmichaelbeaumont
andcommitted
chore(bors): merge pull request #535
535: fix: listen on the IPv6 unspecified address r=tiagolobocastro a=michaelbeaumont ## Description Use the IPv6 unspecified address instead of IPv4 so IPv6/dual stack clusters work. ## Motivation and Context Closes openebs/mayastor#1730 Mayastor is currently unusable when the IPv6 is the primary IP family. ## How Has This Been Tested? I've only tested the helm chart changes. ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <! Co-authored-by: Mike Beaumont <[email protected]>
2 parents 8055f61 + eb0d508 commit 6238e84

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

call-home/src/bin/stats/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ struct Cli {
4444
release_name: String,
4545

4646
/// TCP address where events stats are exposed.
47-
#[clap(long, short, default_value = "0.0.0.0:9090")]
47+
#[clap(long, short, default_value = "[::]:9090")]
4848
metrics_endpoint: SocketAddr,
4949

5050
/// Interval to update the config map.

chart/templates/mayastor/agents/core/agent-core-deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ spec:
5050
- "--request-timeout={{ .Values.base.default_req_timeout }}"
5151
- "--cache-period={{ .Values.base.cache_poll_period }}"{{ if .Values.base.jaeger.enabled }}
5252
- "--jaeger={{ include "jaeger_url" . }}"{{ end }}
53-
- "--grpc-server-addr=0.0.0.0:50051"
53+
- "--grpc-server-addr=[::]:50051"
5454
- "--pool-commitment={{ .Values.agents.core.capacity.thin.poolCommitment }}"
5555
- "--snapshot-commitment={{ .Values.agents.core.capacity.thin.snapshotCommitment }}"
5656
- "--volume-commitment-initial={{ .Values.agents.core.capacity.thin.volumeCommitmentInitial }}"
@@ -94,7 +94,7 @@ spec:
9494
image: "{{ .Values.image.registry }}/{{ .Values.image.repo }}/{{ include "image_prefix" . }}-agent-ha-cluster:{{ default .Values.image.tag .Values.image.repoTags.controlPlane }}"
9595
imagePullPolicy: {{ .Values.image.pullPolicy }}
9696
args:
97-
- "-g=0.0.0.0:50052"
97+
- "-g=[::]:50052"
9898
- "--store=http://{{ include "etcdUrl" . }}"
9999
- "--core-grpc=https://{{ .Release.Name }}-agent-core:50051"{{ if .Values.base.jaeger.enabled }}
100100
- "--jaeger={{ include "jaeger_url" . }}"{{ end }}{{ if .Values.eventing.enabled }}

chart/templates/mayastor/apis/api-rest-deployment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ spec:
4747
args:
4848
- "--dummy-certificates"
4949
- "--no-auth"
50-
- "--http=0.0.0.0:8081"
50+
- "--http=[::]:8081"
5151
- "--request-timeout={{ .Values.base.default_req_timeout }}"{{ if .Values.base.jaeger.enabled }}
5252
- "--jaeger={{ include "jaeger_url" . }}"{{ end }}
5353
- "--core-grpc=https://{{ .Release.Name }}-agent-core:50051"

metrics-exporter/src/bin/io_engine/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ fn get_node_name() -> Result<String, ExporterError> {
4040
#[clap(name = utils::package_description!(), version = utils::version_info_str!())]
4141
pub(crate) struct Cli {
4242
/// TCP address where prometheus endpoint will listen to
43-
#[clap(long, short, default_value = "0.0.0.0:9502")]
43+
#[clap(long, short, default_value = "[::]:9502")]
4444
metrics_endpoint: SocketAddr,
4545

4646
/// Formatting style to be used while logging.

0 commit comments

Comments
 (0)