Skip to content

Commit

Permalink
chore(bors): merge pull request #552
Browse files Browse the repository at this point in the history
552: feat(helm): support IPv6 Pod IPs r=michaelbeaumont a=michaelbeaumont

Incorporates all the changes from openebs/mayastor#1731 into the chart. Depends on the PRs there.

## Description
Use the new separated IP, port args.

## Motivation and Context
See the linked issue.

## Regression
No

## How Has This Been Tested?
Hasn't yet

## Types of changes
<!

Co-authored-by: Mike Beaumont <[email protected]>
  • Loading branch information
mayastor-bors and michaelbeaumont committed Oct 23, 2024
2 parents 599683a + f2dd265 commit 5c0033a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion chart/templates/mayastor/agents/ha/ha-node-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ spec:
args:
- "--node-name=$(MY_NODE_NAME)"
- "--csi-socket={{ default .Values.csi.node.pluginMountPath .Values.csi.node.pluginMounthPath }}/{{ .Values.csi.node.socketPath }}"
- "--grpc-endpoint=$(MY_POD_IP):50053"
- "--grpc-ip=$(MY_POD_IP)"
- "--grpc-port=50053"
- "--cluster-agent=https://{{ .Release.Name }}-agent-core:50052"{{ if .Values.base.jaeger.enabled }}
- "--jaeger={{ include "jaeger_url" . }}"{{ end }}{{ if .Values.eventing.enabled }}
- "--events-url=nats://{{ .Release.Name }}-nats:4222"{{ end }}
Expand Down
3 changes: 2 additions & 1 deletion chart/templates/mayastor/csi/csi-node-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ spec:
- "--node-name=$(MY_NODE_NAME)"
- "--rest-endpoint=http://{{ .Release.Name }}-api-rest:8081"
- "--enable-registration"
- "--grpc-endpoint=$(MY_POD_IP):10199"{{ if .Values.csi.node.nvme.io_timeout }}
- "--grpc-ip=$(MY_POD_IP)"
- "--grpc-port=10199"{{ if .Values.csi.node.nvme.io_timeout }}
- "--nvme-io-timeout={{ .Values.csi.node.nvme.io_timeout }}"
- "--nvme-core-io-timeout={{ .Values.csi.node.nvme.io_timeout }}"{{ else }}
- "--nvme-io-timeout={{ .Values.io_engine.nvme.ioTimeout }}10s"
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/mayastor/io/io-engine-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ spec:
# For example -l 1,2,10-20 means use core 1, 2, 10 to 20.
# Note: Ensure that the CPU resources are updated accordingly.
# If you use 2 CPUs, the CPU: field should also read 2.
- "-g$(MY_POD_IP)"
- "--grpc-ip=$(MY_POD_IP)"
- "-N$(MY_NODE_NAME)"
- "-Rhttps://{{ .Release.Name }}-agent-core:50051"
- "-y/var/local/{{ .Release.Name }}/io-engine/config.yaml"
Expand Down

0 comments on commit 5c0033a

Please sign in to comment.