chore(bors): merge pull request #534

534: refactor: use controllerrevisions to filter data-plane Pods for upgrade r=niladrih a=niladrih



Co-authored-by: Niladri Halder <[email protected]>

constants/src/lib.rs

@@ -27,8 +27,7 @@ pub fn upgrade_event_reason() -> String {
 /// Upgrade job container image repository.
 pub const UPGRADE_JOB_IMAGE_REPO: &str = "openebs";
 /// This is the user docs URL for the Umbrella chart.
-pub const UMBRELLA_CHART_UPGRADE_DOCS_URL: &str =
-    "https://openebs.io/docs/user-guides/upgrade#mayastor-upgrade";
+pub const UMBRELLA_CHART_UPGRADE_DOCS_URL: &str = "https://openebs.io/docs/user-guides/upgrade";
 
 /// Defines the default helm chart release name.
 pub const DEFAULT_RELEASE_NAME: &str = PRODUCT_NAME;
@@ -49,3 +48,6 @@ pub const UMBRELLA_CHART_NAME: &str = "openebs";
 
 /// RECEIVER_API_ENDPOINT is the URL to anonymous call-home metrics collection endpoint.
 pub const CALL_HOME_ENDPOINT: &str = "https://openebs.phonehome.datacore.com/openebs/report";
+
+/// Label key containing controller revision hash for a controller resource for DaemonSets.
+pub const DS_CONTROLLER_REVISION_HASH_LABEL_KEY: &str = "controller-revision-hash";

k8s/upgrade/src/bin/upgrade-job/common/constants.rs

@@ -16,9 +16,6 @@ pub(crate) const IO_ENGINE_LABEL: &str = "app=io-engine";
 /// This is the shared Pod label of the <helm-release>-agent-core Deployment.
 pub(crate) const AGENT_CORE_LABEL: &str = "app=agent-core";
 
-/// This is the shared label across the helm chart components which carries the chart version.
-pub(crate) use constants::helm_release_version_key;
-
 /// This is the label set on a storage API Node resource when a 'Node Drain' is issued.
 pub fn drain_for_upgrade() -> String {
     format!("{CORE_CHART_NAME}-upgrade")