-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(csi-node): allow listening on IPv6 Pod IPs #872
feat(csi-node): allow listening on IPv6 Pod IPs #872
Conversation
Signed-off-by: Mike Beaumont <[email protected]>
5f5e2a9
to
088c200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like DCO is failing, please amend commit with signature.
Also I suggest not to add the github smart link on the PR description. We use bors with merge, including PR description so everything a branch is pushed there's a github event on the mentioned ticket. In case someone is push a lot of branches for some reason it floods the github ticket.
bors d+ |
✌️ michaelbeaumont can now approve this pull request. To approve and merge a pull request, simply reply with |
@tiagolobocastro so only put the link in the commit message? |
I would suggest leaving it as a comment instead, though now that I think about it, not sure github would then auto close issue in this case. |
@tiagolobocastro sorry wasn't clear, I think I can put it in the merged commit message without flooding the issue. Hmm actually I guess bors controls that. So there's just never a link back to an issue anywhere? |
Signed-off-by: Mike Beaumont <[email protected]>
Signed-off-by: Mike Beaumont <[email protected]>
29acf7e
to
27109e4
Compare
bors try |
tryBuild failed: |
sigh:
I'm tempted to disable jaeger tracing from the tests... bors try |
tryBuild succeeded: |
bors merge |
Build succeeded: |
See openebs/mayastor#1731