Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csi-node): allow listening on IPv6 Pod IPs #872

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like DCO is failing, please amend commit with signature.
Also I suggest not to add the github smart link on the PR description. We use bors with merge, including PR description so everything a branch is pushed there's a github event on the mentioned ticket. In case someone is push a lot of branches for some reason it floods the github ticket.

@tiagolobocastro
Copy link
Contributor

bors d+

@bors-openebs-mayastor
Copy link

✌️ michaelbeaumont can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@michaelbeaumont
Copy link
Contributor Author

@tiagolobocastro so only put the link in the commit message?

@tiagolobocastro
Copy link
Contributor

tiagolobocastro commented Oct 9, 2024

@tiagolobocastro so only put the link in the commit message?

I would suggest leaving it as a comment instead, though now that I think about it, not sure github would then auto close issue in this case.
So feel free to do whatever makes more sense to you.

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Oct 9, 2024

@tiagolobocastro sorry wasn't clear, I think I can put it in the merged commit message without flooding the issue. Hmm actually I guess bors controls that. So there's just never a link back to an issue anywhere?

@michaelbeaumont
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 9, 2024
@bors-openebs-mayastor
Copy link

try

Build failed:

@tiagolobocastro
Copy link
Contributor

sigh:

[2024-10-09T19:16:56.607Z] OpenTelemetry trace error occurred. Exporter otlp encountered the following error(s): the grpc server returns error (The service is currently unavailable): , detailed error message: error trying to connect: tcp connect error: Connection refused (os error 111)

I'm tempted to disable jaeger tracing from the tests...

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Oct 9, 2024
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@michaelbeaumont
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 3825922 into openebs:develop Oct 14, 2024
4 checks passed
@michaelbeaumont michaelbeaumont deleted the feat/csi-node-ipv6-args branch October 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants