Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (provisioner-localpv): Support config device type #145

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nobiit
Copy link
Contributor

@nobiit nobiit commented Sep 25, 2022

Pull Request template

Why is this PR required? What issue does it fix?:
There is currently no way to explicitly specify DeviceType in BlockDeviceClaim

What this PR does?:
Support a property named DeviceType and include it when creating BlockDeviceClaim

Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::

  • Create a Storage Class and a corresponding PersistentVolumeClaim with a DeviceType property. Make sure it creates a BlockDeviceClaim with DeviceType

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

The PR title message must follow convention:
<type>(<scope>): <subject>.

Where:
Most common types are:
* feat - for new features, not a new feature for build script
* fix - for bug fixes or improvements, not a fix for build script
* chore - changes not related to production code
* docs - changes related to documentation
* style - formatting, missing semi colons, linting fix etc; no significant production code changes
* test - adding missing tests, refactoring tests; no production code change
* refactor - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
* cherry-pick - if PR is merged in master branch and raised to release branch(like v0.4.x)

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@nobiit nobiit changed the title (feat) provisioner-localpv: Support config device type feat (provisioner-localpv): Support config device type Sep 25, 2022
@niladrih
Copy link
Member

Could you also add user documentation for this feature in the https://github.com/openebs/dynamic-localpv-provisioner/tree/develop/docs/tutorials/device directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants