Fill in codegen gaps for means #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengShi-1
reviewed
Mar 24, 2025
| @@ -1 +1,9 @@ | |||
| # todo: https://github.com/opendp/dp-wizard/issues/275 | |||
| print( | |||
| f"DP means for COLUMN_NAME " | |||
There was a problem hiding this comment.
COLUMN_NAME here may need to be dynamic?
There was a problem hiding this comment.
It is. All of these template files substitute values where there are string in ALLCAPS.
There was a problem hiding this comment.
... but if you're just looking at this file in isolation, how would a new developer know that? There's another PR
that would let us pull these templates closer to where they are used, and that might help.
|
One little comment added about intervals. The templating could also use a better explanation, but there might be bigger changes there soon-ish. Thanks for review, @ChengShi-1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plotting and reporting for means
I would like to keep that issue open because this doesn't yet report accuracy for DP means.
The logic is kind of different if there are or aren't groups. I've filed an issue upstream to see if some of these differences could be ironed out
group_by([])be allowed? opendp#2313... but I'm not sure this will be feasible.
For the reviewer: