Add info to help users compare analysis choices #281
+50
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The layout looks good, and the text is helpful, I think this is a good addition. Is there a plan for when quantile will be implemented? I think it would be good to say something in the text about the quantile not being implemented yet, just to avoid confusion. If quantile is going to be added soon though, I think it's ok as is.
|
Thanks for the review. How about if we just keep this on hold until quantiles are implemented? I don't want TODOs in the UI, but I also can't give much advice when there are only two options. I'll switch this to a draft, and resurface it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reviewer: