Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle multiple contact points #668

Merged
merged 4 commits into from
Feb 20, 2025
Merged

fix: handle multiple contact points #668

merged 4 commits into from
Feb 20, 2025

Conversation

abulte
Copy link
Contributor

@abulte abulte commented Feb 20, 2025

Fix ecolabdata/ecospheres#534

data.gouv.fr expose maintenant (fait en démo, en prod d'ici fin de semaine) les points de contact sous forme de liste opendatateam/udata#3149.

Cette PR permet de gérer une liste vs un item unique.

data.gouv.fr introduit aussi une notion de role. Pour l'instant (iso-fonctionnel), on n'affiche que role == contact. Vu avec data.gouv.fr, se synchroniser pour voir le traitement sur les autres rôles.

Au passage :

  • meilleur typage de dcatExtras (crash sur service-de-force-de-securite-2 fixé)
  • meilleur typage du contactPoint en fonction du modèle udata

Exemples :

  • point-numerique-cc-grand-chambord
  • 5808de39c751df1e0679df72
  • 67b42e2a11a9813d380bbd5b (multiple)

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit 2e11fc8
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/67b74d33563ac400088d4a45
😎 Deploy Preview https://deploy-preview-668--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abulte abulte requested review from narduin and streino February 20, 2025 08:29
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit 2e11fc8
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/67b74d33b7167700089fe07c
😎 Deploy Preview https://deploy-preview-668--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@narduin narduin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas réussi à trouver un affichage de ces éléments dans les exemples, tu as un lien direct ?

@abulte
Copy link
Contributor Author

abulte commented Feb 20, 2025

@narduin j'ai mis les slugs dans la description de la PR, e.g. http://localhost:5173/datasets/67b42e2a11a9813d380bbd5b

@narduin
Copy link
Contributor

narduin commented Feb 20, 2025

@narduin j'ai mis les slugs dans la description de la PR, e.g. http://localhost:5173/datasets/67b42e2a11a9813d380bbd5b

Je regardais pas au bon endroit j'ai trouvé !

@abulte abulte merged commit 48c6424 into main Feb 20, 2025
8 checks passed
@abulte abulte deleted the fix/contact-points branch February 20, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact point : gérer le nouveau format (liste)
3 participants