[Sync] changes from main branch #1606
Open
+657
−534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils/test/matchers/matchers.go (opendatahub-io#1505) (cherry picked from commit 68c6cae)
…assertions (opendatahub-io#1509) When the e2e test suite starts, it may take a while for some of the owned namespace to become available and in such case the related test would fail, since it does not retry. This commit replace the current synchronous test with an asynchronous one. (cherry picked from commit c35c6c1)
- Refactor the toType test to handle more cases - Add additional cases to toTypes test - Add a specific test for byteToType (cherry picked from commit e1457ab)
… present in the cluster (opendatahub-io#1517) * e2e: add cleanup logic to kserve tests to ensure no KnativeServing is present in the cluster * Fix findings * lint (cherry picked from commit 72443c5)
…rving is present in the cluster" (opendatahub-io#1522) * Revert "e2e: add cleanup logic to kserve tests to ensure no KnativeServing is…" This reverts commit 72443c5. * Fix after rebase (cherry picked from commit 6a762ad)
…ng action (opendatahub-io#1527) (cherry picked from commit bf3c108)
…object type (opendatahub-io#1514) - remove generics from Reconciler struct as it is not needed - set PlatformObject as the base obnject that the Reconciler handles to ensure the reconciler can access to common objects fields (cherry picked from commit 94ac12c)
…ckage (opendatahub-io#1535) (cherry picked from commit 614fea1)
* chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions (cherry picked from commit 8c7fef2)
…hub-io#1541) Co-authored-by: Wen Zhou <[email protected]> (cherry picked from commit d538956)
* Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> (cherry picked from commit bd00c9b)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1606 +/- ##
==========================================
+ Coverage 20.01% 20.24% +0.23%
==========================================
Files 160 159 -1
Lines 10982 10910 -72
==========================================
+ Hits 2198 2209 +11
+ Misses 8549 8465 -84
- Partials 235 236 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria