Add configuration to pipeline stanza of DSC to enable InstructLab pipeline

[lburgazzoli]

Description

This PR adds an configuration option to the DataSciencePipelines component configuration to enabled InstructLab pipelines:

apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: default-dsc
spec:
  components:
    codeflare:
      managementState: Removed
    dashboard:
      managementState: Removed
    datasciencepipelines:
      managementState: Managed
      managedPipelines:
        instructLab:
          state: Managed

Once configured, the PREINSTALLEDPIPELINES property of the DataSciencePipelines's params.env file will looks like:

➜ cat opt/manifests/datasciencepipelines/base/params.env | grep PREINSTALLEDPIPELINES   
PREINSTALLEDPIPELINES="{\"instructLab\":{\"state\":\"Removed\"}}"

https://issues.redhat.com/browse/RHOAIENG-16509

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lburgazzoli. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: Patch coverage is 18.18182% with 36 lines in your changes missing coverage. Please review.

Project coverage is 20.00%. Comparing base (2384ada) to head (16ad243).

Files with missing lines	Patch %	Lines
...nents/datasciencepipelines/datasciencepipelines.go	0.00%	16 Missing ⚠️
...tasciencepipelines/datasciencepipelines_support.go	42.10%	8 Missing and 3 partials ⚠️
...pelines/datasciencepipelines_controller_actions.go	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   19.96%   20.00%   +0.04%     
==========================================
  Files         162      162              
  Lines       10964    10996      +32     
==========================================
+ Hits         2189     2200      +11     
- Misses       8541     8559      +18     
- Partials      234      237       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aduquett]

Added text suggestions.

[github-actions]

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12705522276

[github-actions]

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12705547559

[github-actions]

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12902820594

[github-actions]

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12902824301

[lburgazzoli]

@HumairAK should I also change the related params.env var from PREINSTALLEDPIPELINES to MANAGEDPIPELINES ?

[HumairAK]

@lburgazzoli yes I think that's good to do, to be consistent, we'll make the changes on dsp side as well
cc @gmfrasca

[zdtsw]

so, we shall expect in opt/manifests/datasciencepipelines/base/params.env with two new entries, e.g:

MANAGEDPIPELINES="{\"instructLab\":{\"state\":\"Removed\"}}"
PLATFORMVERSION=2.18.0

precheck if KFTO is enabled or not will be done in DSPO, not ODH operator, is that correct?
no indication nor warning should be seen from DSC

need to updated with new example .spec.components.datasciencepipelines.managedPipelines.instructLab
https://github.com/opendatahub-io/opendatahub-operator/blob/main/README.md#example-datasciencecluster

[zdtsw]

why not have the platform version set done in func (s *componentHandler) Init(_ common.Platform)

[lburgazzoli]

done

[lburgazzoli]

need to updated with new example .spec.components.datasciencepipelines.managedPipelines.instructLab https://github.com/opendatahub-io/opendatahub-operator/blob/main/README.md#example-datasciencecluster

done

[zdtsw]

LGTM

[mprahl]

The API definition looks good to me.