Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/12783-error-for-dup-model-name #3708

Conversation

gitdallas
Copy link
Contributor

fises: https://issues.redhat.com/browse/RHOAIENG-12783

Description

model name field will check against existing names and give an error help text if it matches one, it will also prevent form submission
image

How Has This Been Tested?

tested locally by using duplicate model name while trying to register a new model

Test Impact

added a test to check that duplicate model name prevents form submission

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from manaswinidas and ppadti January 31, 2025 23:22
@gitdallas gitdallas requested a review from mturley January 31, 2025 23:22
@gitdallas gitdallas force-pushed the fix/error-for-dupe-model-name branch from 22bc434 to 63af785 Compare February 3, 2025 13:54
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.25%. Comparing base (59320c8) to head (f958232).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3708   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files        1463     1463           
  Lines       33746    33753    +7     
  Branches     9358     9360    +2     
=======================================
+ Hits        28433    28440    +7     
  Misses       5313     5313           
Files with missing lines Coverage Δ
...elRegistry/screens/RegisterModel/RegisterModel.tsx 83.33% <100.00%> (+2.77%) ⬆️
...pages/modelRegistry/screens/RegisterModel/utils.ts 82.00% <100.00%> (+1.56%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59320c8...f958232. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit about the abstraction

@gitdallas gitdallas force-pushed the fix/error-for-dupe-model-name branch from 63af785 to dd95778 Compare February 4, 2025 22:18
@gitdallas gitdallas requested a review from mturley February 4, 2025 22:18
@gitdallas gitdallas force-pushed the fix/error-for-dupe-model-name branch from da9dbf8 to f958232 Compare February 5, 2025 20:39
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @gitdallas , thank youuuuu for your patience with nitpicks

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2025
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8024849 into opendatahub-io:main Feb 5, 2025
30 checks passed
ashley-o0o pushed a commit to ashley-o0o/odh-dashboard that referenced this pull request Feb 7, 2025
* fix/12783-error-for-dup-model-name

Signed-off-by: gitdallas <[email protected]>

* refactor model loading and model name validation

Signed-off-by: gitdallas <[email protected]>

* fix broken error message, add test

Signed-off-by: gitdallas <[email protected]>

* add util unit tests

Signed-off-by: gitdallas <[email protected]>

---------

Signed-off-by: gitdallas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants