-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kserve without serverless #3694
base: main
Are you sure you want to change the base?
Use kserve without serverless #3694
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3694 +/- ##
==========================================
- Coverage 84.16% 84.14% -0.03%
==========================================
Files 1453 1455 +2
Lines 33865 33881 +16
Branches 9384 9395 +11
==========================================
+ Hits 28504 28510 +6
- Misses 5361 5371 +10
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
import React from 'react'; | ||
import { Alert, AlertActionCloseButton, StackItem } from '@patternfly/react-core'; | ||
|
||
export const NoAuthAlert: React.FC<{ setAlertVisible: (isVisible: boolean) => void }> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having an onClose
callback makes more sense because the boolean param is never set to anything other than false
.
export const NoAuthAlert: React.FC<{ setAlertVisible: (isVisible: boolean) => void }> = ({ | |
export const NoAuthAlert: React.FC<{ onClose: () => void }> = ({ |
@emilys314 do you need to wait on the dependent operator PR to merge first? If so, put this PR on hold until then. |
/hold |
Closes https://issues.redhat.com/browse/RHOAIENG-16490
Depends on opendatahub-io/opendatahub-operator#1565
Description
This extends the defaultDeploymentMode by checking if serverless is available on the cluster. If it's not, we can default kserve to raw.
When serverless is removed but raw is enabled:
If autherino is not installed and serverless is selected:
If autherino is not installed and raw selected:
How Has This Been Tested?
Overriding the dsc status in chrome networking to add the following:
components.kserve.serverlessMode
to"serverlessMode": "Removed"
Test Impact
Added a cypress test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
@yih-wang
After the PR is posted & before it merges:
main