fix editing modelmesh prefill (#3383)

opendatahub-io · Oct 24, 2024 · d801754 · d801754
1 parent 1531e12
commit d801754
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 3 deletions.
diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/modelServing/servingRuntimeList.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/modelServing/servingRuntimeList.cy.ts
@@ -27,6 +27,7 @@ import {
   createServingRuntimeModal,
   editServingRuntimeModal,
   inferenceServiceModal,
+  inferenceServiceModalEdit,
   kserveModal,
   kserveModalEdit,
   modelServingSection,
@@ -471,6 +472,38 @@ describe('Serving Runtime List', () => {
       });
     });
 
+    it('Edit ModelMesh model', () => {
+      initIntercepts({
+        projectEnableModelMesh: true,
+        disableKServeConfig: false,
+        disableModelMeshConfig: true,
+        inferenceServices: [
+          mockInferenceServiceK8sResource({
+            name: 'ovms-testing',
+            displayName: 'OVMS ONNX',
+            isModelMesh: true,
+          }),
+        ],
+      });
+
+      projectDetails.visitSection('test-project', 'model-server');
+
+      modelServingSection
+        .getModelMeshRow('OVMS Model Serving')
+        .findDeployedModelExpansionButton()
+        .click();
+      modelServingSection.getInferenceServiceRow('OVMS ONNX').findKebabAction('Edit').click();
+      inferenceServiceModalEdit.shouldBeOpen();
+      inferenceServiceModalEdit
+        .findServingRuntimeSelect()
+        .should('have.text', 'OVMS Model Serving')
+        .should('be.enabled');
+      inferenceServiceModalEdit
+        .findExistingConnectionSelect()
+        .should('have.text', 'Test Secret')
+        .should('be.enabled');
+    });
+
     it('ModelMesh ServingRuntime list', () => {
       initIntercepts({
         projectEnableModelMesh: true,

diff --git a/...pages/modelServing/screens/projects/InferenceServiceModal/ManageInferenceServiceModal.tsx b/...pages/modelServing/screens/projects/InferenceServiceModal/ManageInferenceServiceModal.tsx
@@ -63,10 +63,13 @@ const ManageInferenceServiceModal: React.FC<ManageInferenceServiceModalProps> =
       registeredModelDeployInfo,
     );
 
+  const hasEditInfo = !!editInfo;
   React.useEffect(() => {
-    setCreateData('project', currentProjectName);
-    setCreateData('servingRuntimeName', currentServingRuntimeName);
-  }, [setCreateData, currentProjectName, currentServingRuntimeName]);
+    if (!hasEditInfo) {
+      setCreateData('project', currentProjectName);
+      setCreateData('servingRuntimeName', currentServingRuntimeName);
+    }
+  }, [setCreateData, currentProjectName, currentServingRuntimeName, hasEditInfo]);
 
   const storageCanCreate = (): boolean => {
     if (createData.storage.type === InferenceServiceStorageType.EXISTING_STORAGE) {