Merge pull request #2917 from Gkrumbach07/fix-metric-cols

Refactor useMetricColumnNames to handle empty experimentId
opendatahub-io · Jun 14, 2024 · c9ec3f9 · c9ec3f9
2 parents 48a6201 + 14f80ac
commit c9ec3f9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/frontend/src/concepts/pipelines/content/tables/pipelineRun/useMetricColumnNames.ts b/frontend/src/concepts/pipelines/content/tables/pipelineRun/useMetricColumnNames.ts
@@ -17,7 +17,9 @@ export const useMetricColumnNames = (experimentId: string, metricsNames: Set<str
     ],
     [firstDefaultMetricColumn, secondDefaultMetricColumn],
   );
-  const metricsColumnNames = storedMetricsColumnNames ?? defaultMetricsColumnNames;
+  const metricsColumnNames = experimentId
+    ? storedMetricsColumnNames ?? defaultMetricsColumnNames
+    : [];
 
   // Set default metric columns in localStorage when no prior stored
   // columns exist and at least 1 metric exists to use as a default.