Skip to content

Commit

Permalink
Merge pull request #91 from hbelmiro/RHOAIENG-13327
Browse files Browse the repository at this point in the history
UPSTREAM: <carry>: Fixed importer component when podToPodTLS is true
  • Loading branch information
HumairAK authored Oct 24, 2024
2 parents 1f957b5 + a93c860 commit 57a2823
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions backend/src/v2/compiler/argocompiler/importer.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package argocompiler
import (
"fmt"
"github.com/kubeflow/pipelines/backend/src/apiserver/common"
"strconv"

wfapi "github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
"github.com/kubeflow/pipelines/api/v2alpha1/go/pipelinespec"
Expand Down Expand Up @@ -79,6 +80,7 @@ func (c *workflowCompiler) addImporterTemplate() string {
fmt.Sprintf("$(%s)", component.EnvPodUID),
"--mlmd_server_address", common.GetMetadataGrpcServiceServiceHost(),
"--mlmd_server_port", common.GetMetadataGrpcServiceServicePort(),
"--metadataTLSEnabled", strconv.FormatBool(common.GetMetadataTLSEnabled()),
}
importerTemplate := &wfapi.Template{
Name: name,
Expand Down
2 changes: 2 additions & 0 deletions backend/src/v2/compiler/argocompiler/testdata/importer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ spec:
- "metadata-grpc-service"
- --mlmd_server_port
- "8080"
- --metadataTLSEnabled
- "false"
command:
- launcher-v2
env:
Expand Down
4 changes: 3 additions & 1 deletion backend/src/v2/metadata/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ func NewClient(serverAddress, serverPort string, tlsEnabled bool) (*Client, erro

creds := insecure.NewCredentials()
if tlsEnabled {
config := &tls.Config{}
config := &tls.Config{
InsecureSkipVerify: true, // This should be removed by https://issues.redhat.com/browse/RHOAIENG-13871
}
creds = credentials.NewTLS(config)
}

Expand Down

0 comments on commit 57a2823

Please sign in to comment.