Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containerRuntimeExecutor key/value for WC ConfigMap #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmfrasca
Copy link
Member

  • config option is deprecated as of Argo 3.4 and will break WC startup

The issue resolved by this Pull Request:

Resolves RHOAIENG-11816

Description of your changes:

Testing instructions

  • Deploy DSPO and a simple DSPA using a RHOAI v2.13+ image
  • Ensure WorkflowController comes up
  • Check the ds-pipeline-workflow-controller-{{.Name}} ConfigMap in DSPA namespace and ensure containerRuntimeExecutor key no longer exists

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- config option is deprecated as of Argo 3.4 and will break WC startup

Signed-off-by: Giulio Frasca <[email protected]>
Copy link
Contributor

openshift-ci bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gmfrasca. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-694
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/694/head
git checkout -b pullrequest 5ac055ae3b0d1e73265c23f88fc9c0d7b047a5ac
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-694"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@gmfrasca
Copy link
Member Author

/hold - until DSP is using Argo v3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants