Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add masking of Sentinel-2 pixels valued 1 to the StatsGM plugin #95

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add masking of Sentinel-2 pixels valued 1 to the StatsGM plugin #95

wants to merge 4 commits into from

Conversation

vikineema
Copy link
Contributor

No description provided.

@vikineema vikineema marked this pull request as ready for review June 5, 2023 06:31
SpacemanPaul
SpacemanPaul requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Victoria.

If you still want this change merged, could you please add a new config parameter to the plugin to enable the feature, rather than hard-coding on mask band name? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpacemanPaul SpacemanPaul SpacemanPaul requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikineema @SpacemanPaul