Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stripe issue in landcover level34 #175

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Dec 2, 2024

As the title, changes:

  • include only "clear" observation from wo for water_frequency and normalise against total valid observations.
  • remove water_season from level1, use wo frequency band in level34 instead

The csv is updated accordingly https://dea-public-data-dev.s3-ap-southeast-2.amazonaws.com/lccs_validation/c3/data_to_plot/lccs_colour_scheme_golden_dark_au_c3.csv

@emmaai emmaai requested review from JM-GA and tebadi December 2, 2024 06:44
@emmaai emmaai changed the title Fix stripes issue in landcover level34 Fix stripe issue in landcover level34 Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.20%. Comparing base (7e56476) to head (af02544).

Files with missing lines Patch % Lines
odc/stats/plugins/lc_fc_wo_a0.py 88.46% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #175      +/-   ##
===========================================
- Coverage    81.24%   81.20%   -0.04%     
===========================================
  Files           50       50              
  Lines         4532     4528       -4     
===========================================
- Hits          3682     3677       -5     
- Misses         850      851       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tebadi tebadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the logic but the code looks good.

wet_clear = expr_eval(
"where(b>0, _nan, a)",
{"a": wet_clear, "b": raw_mask.data},
name="get_lear_pixels",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lear->clear

@emmaai emmaai merged commit d04b1c0 into develop Dec 4, 2024
3 checks passed
@emmaai emmaai deleted the fix_stripes_lc_level34 branch December 4, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants