Differentiate mangroves and other aquatic veg #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tebadi
reviewed
Nov 15, 2024
| dtype="uint8", | ||
| ) | ||
| l4 = expr_eval( | ||
| "where((a==124)&(b==12)&(c==2), 81, a)", | ||
| ########################################## |
tebadi
reviewed
Nov 15, 2024
| dtype="uint8", | ||
| ) | ||
| ######################################### |
tebadi
reviewed
Nov 15, 2024
|
|
||
| l4 = expr_eval( | ||
| "where((a==124)&(b==13)&(c==2)&(d==2), 86, a)", | ||
| ########################################## |
tebadi
reviewed
Nov 15, 2024
| dtype="uint8", | ||
| ) | ||
|
|
||
| l4 = expr_eval( | ||
| "where((a==124)&(b==10)&(c==2)&(d==2), 80, a)", | ||
| ######################################### |
There was a problem hiding this comment.
it's not unwanted. It's meant to be there to section the code
unwanted artefact
tebadi
approved these changes
Nov 15, 2024
emmaai
added a commit
that referenced
this pull request
Nov 18, 2024
* Changed the band names to match the config files. Also updated vegetation , lifeform and water seasonality to correctly replace nodata * Fixed a typo in the name of the expression in the water sesonality * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update the path to the urban model on s3 * Differentiate mangroves and other aquatic veg (#170) * differentiate mangroves and other aquatic veg * fix level1 test --------- Co-authored-by: Emma Ai <[email protected]> * Fixed a few errors after rewriting the logic on aquatic vegetation --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Emma Ai <[email protected]> Co-authored-by: Emma Ai <[email protected]>
emmaai
added a commit
that referenced
this pull request
Nov 24, 2024
* Changed the band names to match the config files. Also updated vegetation , lifeform and water seasonality to correctly replace nodata * Fixed a typo in the name of the expression in the water sesonality * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update the path to the urban model on s3 * Differentiate mangroves and other aquatic veg (#170) * differentiate mangroves and other aquatic veg * fix level1 test --------- Co-authored-by: Emma Ai <[email protected]> * Fixed a few errors after rewriting the logic on aquatic vegetation * Ensured nodata is replaced with 255 in all level4 plugins * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove debugging code * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Corrected the implementation of water seasonality and water persistence. Also made a range of other mappings at Level 4 based on the latest understanding of Collection 2 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Mock the veg and bare thresholds in the unit test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Cleaned the code and removed redundant checks at level4 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Applied more code cleaning --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Emma Ai <[email protected]> Co-authored-by: Emma Ai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
mangroves=124andothers=125in level 1