Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in cultivated and woody cover plugins #149

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Aug 23, 2024

Addressed issues:

  • results from cultivated and woody cover run with pipeline showed discrepancy on tiles randomly from run to run, after investigations and experiments, confirmed that it's caused by numexpr package, the relevant issue was raised Multithreading support pydata/numexpr#494
  • input bands missing due to unavailable inputs from even upper streams, hence allow the graceful exist.

Note:
I have put into a hot (means very hacky) fix for the numexpr package, which is remarked in the docker file. We must follow up on this issue and address in the future.

@emmaai emmaai force-pushed the fix_precision_issue branch from db4809f to 756665f Compare August 23, 2024 06:55
Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks reasonable to me. Hopefully we get prompt action from the folks at numexpr.

@emmaai emmaai merged commit 6a29afa into develop Aug 26, 2024
9 checks passed
@emmaai emmaai deleted the fix_precision_issue branch August 26, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants