Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin of urban model for landcover #143

Merged
merged 6 commits into from
Jul 24, 2024
Merged

plugin of urban model for landcover #143

merged 6 commits into from
Jul 24, 2024

Conversation

emmaai
Copy link
Contributor

@emmaai emmaai commented Jul 18, 2024

Major change:

  • add plugin for urban model
  • make TensorFlow multithreading safely with dask worker and threads

The diagram is as below:
image
Minor change:

  • update dependencies in docker image

Note:
The performance/accuracy of model itself is not guaranteed in this implementation. It was and will be dealt with separately.

@emmaai emmaai requested review from omad, SpacemanPaul and Ariana-B July 18, 2024 09:51
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 86.09626% with 26 lines in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (89ddfb8) to head (ab56f58).

Files Patch % Lines
odc/stats/plugins/lc_tf_urban.py 76.53% 23 Missing ⚠️
odc/stats/proc.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
+ Coverage    78.00%   78.41%   +0.40%     
===========================================
  Files           40       43       +3     
  Lines         3738     3924     +186     
===========================================
+ Hits          2916     3077     +161     
- Misses         822      847      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmaai emmaai merged commit a090eb6 into develop Jul 24, 2024
10 checks passed
@emmaai emmaai deleted the tf_urban_plugin branch July 24, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants