-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance fixes #202
Merged
Maintenance fixes #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- accept initialized client instead of credentials - use that to run tests with mocks instead of patching that stopped working when imports were moved into functions
shapely 2+ has tighter type annotations I guess
- remove pragmas from test code - add .pylintrc in test folder
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 94.05% 94.91% +0.86%
===========================================
Files 33 33
Lines 5649 5663 +14
===========================================
+ Hits 5313 5375 +62
+ Misses 336 288 -48 ☔ View full report in Codecov by Sentry. |
- fixes for pylint 3 series
- inlcude types for shapely - use minimal matplotlib - add azure-storage-blob for az tests
this is to shut up the warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint
andblack
pylint
pragmas