Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ditch docker from CI #1675

Open
wants to merge 14 commits into
base: develop-1.9
Choose a base branch
from
Open

Ditch docker from CI #1675

wants to merge 14 commits into from

Conversation

omad
Copy link
Member

@omad omad commented Dec 2, 2024 •
edited by github-actions bot
Loading

Ditch Docker for testing in CI

  • It's slow
  • It's complicated
  • It's unnecessary

This PR branches from #1670, which should be merged first.

Also

  • Run linting and testing in a single workflow but as different jobs, so that expensive build steps are skipped if linting fails.
  • Split the documentation tests. The RTD Preview commenter should live on it's own.
  • Use GHA Concurrency controls to quickly cancel builds if new pushes arrive.

Proposed changes

  • Closes #xxxx

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

📚 Documentation preview 📚: https://datacube-core--1675.org.readthedocs.build/en/1675/

@omad omad force-pushed the dra/ditch-docker-from-ci branch from 37ae0a1 to edd03af Compare December 2, 2024 02:30
omad added 2 commits December 2, 2024 14:20
@omad
Streamline GitHub Actions Runs
773e7f3 
- Don't double run (For both PR and Push to any branch)
- Cancel if a new Run starts
@omad
Don't double run conda smoke test CI
7b1d1d5
@omad omad force-pushed the dra/ditch-docker-from-ci branch from edd03af to 01a5bf4 Compare December 2, 2024 03:22
@omad omad force-pushed the dra/ditch-docker-from-ci branch from 01a5bf4 to 2914466 Compare December 2, 2024 03:46
omad added 2 commits December 2, 2024 14:54
@omad
Fix GHA workflow concurrency
8e34a41 
I'd set only a single workflow per branch, this makes it 
one workflow per workflow+branch.
@omad
Try and fix CI DB tests
3870f51
@omad omad force-pushed the dra/ditch-docker-from-ci branch 2 times, most recently from db7f64e to f47e563 Compare December 3, 2024 00:18
@omad
More fix attempts (segfaults!?)
be2f8ca 
Try more python versions
@omad omad force-pushed the dra/ditch-docker-from-ci branch from f47e563 to be2f8ca Compare December 4, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omad