-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alembic-managed schema migrations for postgis driver. (cleaned up git history) #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1520 +/- ##
===============================================
- Coverage 85.37% 85.16% -0.22%
===============================================
Files 137 139 +2
Lines 14784 14895 +111
===============================================
+ Hits 12622 12685 +63
- Misses 2162 2210 +48 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
The database schema for the postgres database has been frozen for years because making schema changes requires manually writing code to check whether an update is required and applying said update.
Alembic is a schema migration framework for SQLAlchemy that automates much of this.
Proposed changes
datacube system init
for the postgis index driver now uses Alembic to detect what schema upgrades are required and apply them.N.B. Some remaining coverage gaps that can't really be filled until we have some actual migrations lined up.
docs/about/whats_new.rst
for all changes