-
-
Notifications
You must be signed in to change notification settings - Fork 55.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clipping bug in SQDIFF_NORMED template matching #20003
Fix clipping bug in SQDIFF_NORMED template matching #20003
Conversation
03e0b2e
to
b4be860
Compare
Hi @vpisarev! I'm having some trouble addressing the last few failing tests for the CL builds + Mac build. They all seem to be the same, and I can't replicate locally. It looks like the norm is still being clipped at 1 when the difference is computed - do you have any thoughts/suggestions? |
There is OpenCL implementation of |
@asmorkalov yes I saw that - I made changes to the function in that file to match the new logic, but it doesn't appear to be addressing the issue. With SQDIFF Normed, we should just be taking the numerator and the denominator with no conditionals. |
@alalek I created PR opencv/opencv_extra#916 for sanity check update. Please take a look. |
@asmorkalov Public CI is not able to collect patches from different users (not implemented because it is unusual case) |
Replacement: #20770 |
Addresses #15215 regarding
CV_TM_SQDIFF_NORMED
clipping at 1.0, despite the range being > 1. The test case is the example presented in the ticket.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.