README: Use relative links to the proposals#51
Merged
caniszczyk merged 1 commit intoopencontainers:masterfrom Apr 6, 2018
Merged
README: Use relative links to the proposals#51caniszczyk merged 1 commit intoopencontainers:masterfrom
caniszczyk merged 1 commit intoopencontainers:masterfrom
Conversation
There's no need to use absolute links for these. And using relative links sets a good example for future proposals, because the links will work in the proposal branch's README before the referenced proposal lands in the TOB master. There's a similar absolute link for the code-of-conduct in the distribution proposal. The intention may have been to show the absolute URL which would be included in new project's repository. I don't think that matters, because the project template has included a similar link since opencontainers/project-template@ee72bc89 (CONTRIBUTING: Code of conduct, meetings, mailing list, and IRC, 2016-09-08, opencontainers#45), so I've left that alone here. Signed-off-by: W. Trevor King <wking@tremily.us>
wking
force-pushed
the
readme-relative-links
branch
from
f8ff9a4 to
d9708b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to use absolute links for these. And using relative links sets a good example for future proposals, because the links will work in the proposal branch's README before the referenced proposal lands in the TOB master.
There's a similar absolute link for the code-of-conduct in the distribution proposal. The intention may have been to show the absolute URL which would be included in new project's repository. I don't think that matters, because the project template has included a similar link since opencontainers/project-template@ee72bc89 (opencontainers/project-template#45), so I've left that alone here.