Skip to content

[RFC] cmd/oci-runtime-tool: new flags for linux.intelRdt #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[RFC] cmd/oci-runtime-tool: new flags for linux.intelRdt #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cmd/oci-runtime-tool/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
cli.StringSliceFlag{Name: "linux-hugepage-limits-add", Usage: "add hugepage resource limits"},
cli.StringSliceFlag{Name: "linux-hugepage-limits-drop", Usage: "drop hugepage resource limits"},
cli.StringFlag{Name: "linux-intelRdt-closid", Usage: "RDT Class of Service, i.e. group under the resctrl pseudo-filesystem which to associate the container with"},
cli.BoolFlag{Name: "linux-intelRdt-enableMonitoring", Usage: "Enable resctrl monitoring for the container"},
cli.StringSliceFlag{Name: "linux-intelRdt-schema", Usage: "Specifies the resctrl schema. May be specified multiple times to set multiple schemata."},
cli.StringFlag{Name: "linux-intelRdt-l3CacheSchema", Usage: "specifies the schema for L3 cache id and capacity bitmask"},
cli.StringSliceFlag{Name: "linux-masked-paths", Usage: "specifies paths can not be read inside container"},
cli.Uint64Flag{Name: "linux-mem-kernel-limit", Usage: "kernel memory limit (in bytes)"},
Expand Down Expand Up @@ -749,6 +751,12 @@
if context.IsSet("linux-intelRdt-closid") {
g.SetLinuxIntelRdtClosID(context.String("linux-intelRdt-closid"))
}
if context.IsSet("linux-intelRdt-enableMonitoring") {
g.SetLinuxIntelRdtEnableMonitoring(context.Bool("linux-intelRdt-enableMonitoring"))

Check failure on line 755 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / lint 

g.SetLinuxIntelRdtEnableMonitoring undefined (type *generate.Generator has no field or method SetLinuxIntelRdtEnableMonitoring)

Check failure on line 755 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.22.x) 

g.SetLinuxIntelRdtEnableMonitoring undefined (type *generate.Generator has no field or method SetLinuxIntelRdtEnableMonitoring)

Check failure on line 755 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.21.x) 

g.SetLinuxIntelRdtEnableMonitoring undefined (type *generate.Generator has no field or method SetLinuxIntelRdtEnableMonitoring)

Check failure on line 755 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.23.x, -race) 

g.SetLinuxIntelRdtEnableMonitoring undefined (type *generate.Generator has no field or method SetLinuxIntelRdtEnableMonitoring)

Check failure on line 755 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, -race) 

g.SetLinuxIntelRdtEnableMonitoring undefined (type *generate.Generator has no field or method SetLinuxIntelRdtEnableMonitoring)

Check failure on line 755 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.22.x, -race) 

g.SetLinuxIntelRdtEnableMonitoring undefined (type *generate.Generator has no field or method SetLinuxIntelRdtEnableMonitoring)

Check failure on line 755 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.23.x) 

g.SetLinuxIntelRdtEnableMonitoring undefined (type *generate.Generator has no field or method SetLinuxIntelRdtEnableMonitoring)
}
if context.IsSet("linux-intelRdt-schema") {
g.SetLinuxIntelRdtSchemata(context.StringSlice("linux-intelRdt-schema"))

Check failure on line 758 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / lint 

g.SetLinuxIntelRdtSchemata undefined (type *generate.Generator has no field or method SetLinuxIntelRdtSchemata) (typecheck)

Check failure on line 758 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.22.x) 

g.SetLinuxIntelRdtSchemata undefined (type *generate.Generator has no field or method SetLinuxIntelRdtSchemata)

Check failure on line 758 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.21.x) 

g.SetLinuxIntelRdtSchemata undefined (type *generate.Generator has no field or method SetLinuxIntelRdtSchemata)

Check failure on line 758 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.23.x, -race) 

g.SetLinuxIntelRdtSchemata undefined (type *generate.Generator has no field or method SetLinuxIntelRdtSchemata)

Check failure on line 758 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.21.x, -race) 

g.SetLinuxIntelRdtSchemata undefined (type *generate.Generator has no field or method SetLinuxIntelRdtSchemata)

Check failure on line 758 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.22.x, -race) 

g.SetLinuxIntelRdtSchemata undefined (type *generate.Generator has no field or method SetLinuxIntelRdtSchemata)

Check failure on line 758 in cmd/oci-runtime-tool/generate.go

View workflow job for this annotation

GitHub Actions / test (1.23.x) 

g.SetLinuxIntelRdtSchemata undefined (type *generate.Generator has no field or method SetLinuxIntelRdtSchemata)
}

if context.IsSet("linux-intelRdt-l3CacheSchema") {
g.SetLinuxIntelRdtL3CacheSchema(context.String("linux-intelRdt-l3CacheSchema"))
Expand Down
7 changes: 7 additions & 0 deletions man/oci-runtime-tool-generate.1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,13 @@ read the configuration from `config.json`.
RDT Class of Service, i.e. group under the resctrl pseudo-filesystem, which
to associate the container with.

**--linux-intelRdt-enableMonitoring**=""
Enable resctrl monitoring for the container.

**--linux-intelRdt-schema**=[]
Specifies one resctrl schema. May be specified multiple times to configure the complete schemata.
e.g. --linux-intelRdt-schemata="MB:0=80" --linux-intelRdt-schemata="L3:0=ff"

**--linux-intelRdt-l3CacheSchema**=""
Specifies the schema for L3 cache id and capacity bitmask.

Expand Down
Loading