[DO NOT MERGE] vendor: test opencontainers/cgroups#64#5340
Draft
kolyshkin wants to merge 2 commits into
Draft
Conversation
This was referenced Jun 23, 2026
kolyshkin
force-pushed
the
test-cgroups-drop-ebpf
branch
from
14434d4 to
3345e95
Compare
This new version includes fixes for EPBF fd leaks: opencontainers/cgroups#60 Let's update to it. However, the Stats() method was added in the new release to the interface, so tests were failing with: # github.com/opencontainers/runc/libcontainer [github.com/opencontainers/runc/libcontainer.test] ./container_linux_test.go:125:18: cannot use &mockCgroupManager{…} (value of type *mockCgroupManager) as cgroups.Manager value in struct literal: *mockCgroupManager does not implement cgroups.Manager (missing method Stats) Let's add the method to the mock too. In the future, probably the mock should come from the cgroups module. Signed-off-by: Rodrigo Campos <rodrigo@amutable.com>
Let's drop the second biggest (by size) runc dependency and reduce the binary size by another ~1MB. Draft/DNM until opencontainers/cgroups#64 is merged/released. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
test-cgroups-drop-ebpf
branch
from
3345e95 to
b376143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's drop the second biggest (by size) runc dependency and reduce the binary size by another ~1MB.
Draft/DNM until opencontainers/cgroups#64 is merged/released.