Add skip-in-flight and link-remap criu options for checkpoint and restore #4627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Levi-Minzi <[email protected]>
|
Hmm, if I'm not mistaken, both options are for checkpoint only. |
Signed-off-by: Daniel Levi-Minzi <[email protected]>
I've removed those options from restore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively small PR that exposes the criu options below when using the runc checkpoint and restore functionality.
--tcp-skip-in-flight
: Skip in-flight TCP connections. See
criu --skip-in-flight option.
--link-remap
: Allow one to link unlinked files back when possible. See
criu --link-remap option.
With regards to the lint error below, I followed the naming convention of the already present
TcpEstablishedwhen addingTcpSkipInFlight. I could leave it as it or change both or change just my addition. Though the last option would look a bit weird I think.