Add a new attribute SAI_BFD_SESSION_ATTR_NEXT_HOP_ID to saibfd.h #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/app run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Skipping cap file sample.cap |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
you are causing enum shift: all attributes needs to be added at the end, also you need to force push to single commit all changes with enum shift |
Signed-off-by: Baorong Liu <[email protected]> remove extra space Signed-off-by: Baorong Liu <[email protected]> move new added attr to the end of enum Signed-off-by: Baorong Liu <[email protected]>
baorliu
force-pushed
the
baorliu_sh_bfd_use_nexthop
branch
from
3838d9d to
4fb9d00
Compare
|
updated and squashed old commits to a single commit. thanks |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2127 in repo opencomputeproject/SAI |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@baorliu - would you like to discuss this PR in this week's community meeting? |
kcudnik
approved these changes
Jan 15, 2025
in the middle of validating it in a system now. we can discuss it after I verify the use case with the new attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<re-created the PR, because the original one #2117 was using master branch in forked repo cause the commits were lost when do fork sync.
Please see comments in #2117 for review history>
Adding a new attribute SAI_BFD_SESSION_ATTR_NEXT_HOP_ID to saibfd.h to support forwarding single hop bfd packet to specific nexthop.
The proposed usage is:
1, this attribute can be provided both in create_bfd_session and set_bfd_session_attribute.
2, if SAI_BFD_SESSION_ATTR_USE_NEXT_HOP (optional, default is false) is set to true, BFD session will get next hop from SAI_BFD_SESSION_ATTR_NEXT_HOP_ID value and forward the bfd packet to the next hop. If SAI_BFD_SESSION_ATTR_USE_NEXT_HOP is false, attribute SAI_BFD_SESSION_ATTR_NEXT_HOP_ID will be ignored.
3, when using both SAI_BFD_SESSION_ATTR_HW_LOOKUP_VALID and SAI_BFD_SESSION_ATTR_USE_NEXT_HOP, the implementation is vender dependent.