Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/datamodel 1.0.7 #107

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Issue/datamodel 1.0.7 #107

merged 6 commits into from
Jan 9, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 5, 2024

Pull Request

Description

use pvsite-datamodel 1.0.7
removed some function from get_data, had to adjust some tests

#89

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a5026bb) 36.45% compared to head (5e03080) 30.48%.

Files Patch % Lines
src/sites_toolbox.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   36.45%   30.48%   -5.97%     
==========================================
  Files          15       15              
  Lines         864      797      -67     
==========================================
- Hits          315      243      -72     
- Misses        549      554       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rachel-labri-tipton
Copy link
Collaborator

Hi @peterdudfield, I'm having trouble running the code locally. I updated the pvsite-datamodel but when I try to run the code, I keep getting this error:

Screenshot 2024-01-08 at 17 09 30.

Did you happen to have this issue?

@peterdudfield
Copy link
Contributor Author

I dont, might have to install https://pypi.org/project/h5py/, but seems weird. Is this a new bug for you?

@rachel-labri-tipton
Copy link
Collaborator

yeah, it's a new bug. otherwise, the code looks good. glad those functions are moved into the data model. i went ahead and approved.

@peterdudfield peterdudfield merged commit 322b635 into main Jan 9, 2024
2 of 3 checks passed
@peterdudfield peterdudfield deleted the issue/datamodel-1.0.7 branch January 9, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants