Skip to content

Conversation

@Mo-Gul
Copy link
Contributor

@Mo-Gul Mo-Gul commented Nov 14, 2025

feel free to cherry-pick

@rgieseke
Copy link
Contributor

Good catches!

@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Nov 23, 2025

Any ideas what is missing for a merge?

@rgieseke
Copy link
Contributor

Any ideas what is missing for a merge?

Time and motivation to review :/

It's a very big one and it mixes fixing obvious mistakes, stylistic issues and conceptual changes. It would be much easier to review if you had started with a smaller PR and if they were scoped thematically.

There are also changes that might relate to differences between bibtex, biblatex, ... and I'm not actually not sure what level of compatibility we aim for.

@Mo-Gul
Copy link
Contributor Author

Mo-Gul commented Nov 26, 2025

You are right, most likely it would have been better to split it into some smaller PRs, but I had a "run" ;)
Most likely it is simplest to just click through the single commits to verify that the LOG message delivers what it promises.

@rgieseke
Copy link
Contributor

I cherry-picked the first commits in #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants