Skip to content

build(deps-dev): bump vitest from 4.1.11 to 5.0.5 - #65

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/vitest-5.0.5
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/vitest-5.0.5

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 19, 2026

Copy link
Copy Markdown
Contributor

Bumps vitest from 4.1.11 to 5.0.5.

Release notes

Sourced from vitest's releases.

v5.0.5

   🐞 Bug Fixes

    View changes on GitHub

v5.0.4

   🚀 Features

   🐞 Bug Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 4.1.11 to 5.0.5.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md)
- [Commits](https://github.com/vitest-dev/vitest/commits/v5.0.5/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-version: 5.0.5
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from a team as a code owner October 19, 2026 18:55
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Oct 19, 2026
@clawsweeper

clawsweeper Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Oct 19, 2026
@clawsweeper

clawsweeper Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codex review: blocked before merge.

What this changes

This PR upgrades the development test runner from Vitest 4.1.11 to 5.0.5 and updates its lockfile dependencies.

Example: A contributor runs pnpm install --frozen-lockfile on Node 25.9.0.

  • Before: Vitest 4.1.11 permits Node 25 and the supported dependency graph installs.
  • After: Vitest 5.0.5 excludes Node 25, so strict engine validation rejects installation.

Review scores

Measure Result What it means
Overall readiness 🧂 unranked krab (1/6) The upgrade breaks a supported development installation path and reverses recorded compatibility direction.
Proof confidence 🌊 off-meta tidepool Not applicable: This Dependabot maintenance PR is outside the contributor proof gate; exact-head CI exercises the updated tooling, with Node 25 failing before package checks.
Patch quality 🧂 unranked krab (1/6) 1 actionable review finding remain.

Product

Kind: Maintenance · Worth it: No
User problem: Contributors receive newer test tooling, but supported Node 25 development installs become unusable.
Reason: Recorded owner direction retains Vitest 4.1.11 until Vitest supports Node 25 or the repository changes its runtime contract.

Regression provenance

Possible regression — probable (reviewed change; failure trace). No predecessor PR is attributed.

Merge readiness

⛔ Blocked before merge - 3 items remain

This PR breaks supported Node 25 development installs and contradicts recorded compatibility direction; repository policy does not permit automatic closure of this unimplemented upgrade.

Priority: P2
Reviewed head: 4e37252f816d961dd7f6d6896c7acc837f0e6350

Before merge

Findings

  • [P1] Preserve Node 25-compatible test tooling — package.json:59

Provenance

Agent review details

How this fits together

Vitest runs the router's TypeScript behavior tests during package validation; pnpm validates dependency engines before those tests can start.

flowchart LR
  A[Contributor checkout] --> B[pnpm frozen install]
  B --> C[Dependency engine validation]
  C --> D[Package checks]
  D --> E[Vitest router tests]
  D --> F[Packed package validation]
Loading

Technical review

Best possible solution:

Retain Vitest 4.1.11 until an upgrade supports the repository's declared development runtimes.

Do we have a high-confidence way to reproduce the issue?

The locked Vitest engine range excludes Node 25 under engineStrict, and the exact-head Node 25 job fails during installation while main passes; no target code was executed locally.

Is this the best way to solve the issue?

This upgrade conflicts with the established compatibility contract; retaining the current test runner is preferable to disabling engine checks or removing supported Node coverage.

Full review comments:

Overall correctness: patch is incorrect
Overall confidence: 0.99

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 3b2fb01297a5.

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Likely related people:

  • Vincent Koc: Raw commit f33fdcb adds package.json:54 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: f33fdcbe0f8c; files: package.json)

Labels

Label changes:

  • add P2: The update breaks supported contributor installations without changing the published router runtime.
  • add merge-risk: 🚨 compatibility: The new Vitest engine range excludes the explicitly supported Node 25 development runtime.
  • add merge-risk: 🚨 automation: The changed dependency graph prevents the existing Node 25 CI lane from installing dependencies and reaching package checks.
  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🌊 off-meta tidepool and patch quality is 🧂 unranked krab.
  • add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Label justifications:

  • P2: The update breaks supported contributor installations without changing the published router runtime.
  • merge-risk: 🚨 compatibility: The new Vitest engine range excludes the explicitly supported Node 25 development runtime.
  • merge-risk: 🚨 automation: The changed dependency graph prevents the existing Node 25 CI lane from installing dependencies and reaching package checks.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🌊 off-meta tidepool and patch quality is 🧂 unranked krab.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 19, 2026, 3:08 PM ET / 19:08 UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. merge-risk: 🚨 compatibility 🚨 Merging this PR could break existing users, config, migrations, defaults, or upgrades. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants